search

ARM-software / gator

Sources for Arm Streamline's gator daemon, part of Arm Mobile Studio suite of performance analysis tools
https://www.arm.com/products/development-tools/graphics/arm-mobile-studio
133 stars 70 forks source link

ipc: proto: fix unknown CMake command protobuf_generate_cpp() #38

Closed clementperon closed 1 year ago

clementperon commented 1 year ago

find_package(Protobuf) is used in CONFIG mode and will load the CMake config provided by the protobuf package.

When the Protobuf config is used it requires to set protobuf_MODULE_COMPATIBLE to ON to expose protobuf_generate_cpp()

See: https://github.com/protocolbuffers/protobuf/issues/7912

Instead of using the Protobuf config used the widely cmake module available since at least CMake 3.0.

Signed-off-by: Clément Péron peron.clem@gmail.com

bengaineyarm commented 1 year ago

Hi @clementperon thanks for this. I guess you are using system provided dependencies, rather than using vcpkg?

Possibly there is some difference between the way the vcpkg module presents its self vs no-vcpkg build. Let me test this internally and either merge it or pick an alternative...

bengaineyarm commented 1 year ago

Squashed into https://github.com/ARM-software/gator/pull/39