search

ARM-software / lisa

Linux Integrated System Analysis
Apache License 2.0
203 stars 119 forks source link

lisa._kmod: Add util_est_unified trace events #2182

Closed honxia02 closed 9 months ago

honxia02 commented 9 months ago

FEATURE

Upstream has now removed struct util_est and effectively merged util_est.enqueued and util_est.ewma in a single int field. Provide a new trace event for it so the new kernel can trace it.

This also fixes LISA not being able to compile and load the module on the new kernel. We detect whether struct util_est exists to decide if the new signal should be used.

douglas-raillard-arm commented 9 months ago

LGTM, can you update the commit message to replace "FEATURE and FIX" with just "FEATURE" ? Otherwise as it stands it will appear twice in the changelog (or not at all, can't remember what the regex looks like).

We could add further support in the load_tracking analysis but let's hold off for now until we had a bit more use of that event in case we want to modify something

honxia02 commented 9 months ago

Thanks. Will do.

honxia02 commented 9 months ago

Both the PR and the commit updated.