ARM-software / optimized-routines

Optimized implementations of various library functions for ARM architecture processors
Other
592 stars 94 forks source link

Support building/testing stpcpy #24

Closed pcc closed 4 years ago

pcc commented 4 years ago

In http://r.android.com/1243146 @enh-google noted that the stpcpy implementation in this repository is not currently being built or tested in the optimized-routines repository (it does appear to be built/tested as part of glibc though).

It would be good to support building and testing the stpcpy in this repository given that we're starting to use it on Android.

enh-google commented 4 years ago

(and if you check in a stpcpy.S that's basically #define followed by #include, that makes our build simpler :-) )

Wilco1 commented 4 years ago

You're right, stpcpy was supported but not tested. I've now added a test and a basic stpcpy.S file.

nsz-arm commented 4 years ago

fixed in https://github.com/ARM-software/optimized-routines/commit/9be4a9b833dbdb708f7b9bbd20511ea4b528ccac

enh-google commented 4 years ago

that looks ideal. thanks!