search

ARM-software / synchronization-benchmarks

Collection of synchronization micro-benchmarks and traces from infrastructure applications
Other
38 stars 36 forks source link

Should we add a version comment for the external source code? #6

Closed zoybai closed 6 years ago

zoybai commented 6 years ago

E.g. We cannot easily find the version information from ext/mysql/cas_event_mutex.h and ext/mysql/event_mutex.h. Is it MySQL 5.6 or 5.7?

Should we add a comment in front of each external source code to indicate this? Because MySQL itself may change its synchronization primitives.

lucasclucasdo commented 6 years ago

Zoy, event_mutex is based on MySQL 5.7 and cas_event_mutex is the same code with some proposed improvements (most impactful is avoiding the unnecessary atomic on release replacing with a store-release).

I agree we should have a comment in third-party derived source files which indicate the version of origin.

zoybai commented 6 years ago

Thanks for the explanation. I will add a comment for the new osq_lock once we complete the integration.

geoffreyblake commented 6 years ago

Is this issue closed?

lucasclucasdo commented 6 years ago

I was leaving it open since this info hasn't been added to the source files for any of the existing algorithms yet.