search

ARM-software / tf-issues

Issue tracking for the ARM Trusted Firmware project
37 stars 16 forks source link

'make help' should not trigger dependency checking #112

Closed sandrine-bailleux-arm closed 10 years ago

sandrine-bailleux-arm commented 10 years ago

'make help' triggers dependency checking whereas it shouldn't:

$ make help
  DEPS    build/fvp/release/bl31/bl31.ld.d
  DEPS    build/fvp/release/bl31/sysreg_helpers.d
  DEPS    build/fvp/release/bl31/semihosting_call.d
  DEPS    build/fvp/release/bl31/platform_helpers.d
  DEPS    build/fvp/release/bl31/tlb_helpers.d
  <...>
  usage: make PLAT=<all|fvp> <all|bl1|bl2|bl31|distclean|clean|checkcodebase|checkpatch>

PLAT is used to specify which platform you wish to build.

Supported Targets:
  all            Build the BL1, BL2 and BL31 binaries
  bl1            Build the BL1 binary
  bl2            Build the BL2 binary
 <...>
sandrine-bailleux-arm commented 10 years ago

This bug is due to the way the dependency checking is triggered. The Makefile currently specifies a blacklist of rules for which dependency checking must not be triggered. See https://github.com/ARM-software/arm-trusted-firmware/blob/master/Makefile#L240 and https://github.com/ARM-software/arm-trusted-firmware/blob/master/Makefile#L258 The blacklist includes 'clean', 'realclean' and 'distclean' at the moment. For all other rules (including 'help') dependency checking is triggered.

A blacklist seems a bit fragile. It would be more robust to have a whitelist of rules for which dependency checking must be triggered. It would include all build targets (bl1, bl2, bl31, bl32).

tixy commented 10 years ago

Whitelist should include 'fip' and 'all' too.