search

ARM-software / tf-issues

Issue tracking for the ARM Trusted Firmware project
37 stars 16 forks source link

FIPTOOL variable is not propagated to the fip_create's sub-Makefile #277

Open sandrine-bailleux-arm opened 9 years ago

sandrine-bailleux-arm commented 9 years ago

The top-level Makefile allows to configure the path to the directory containing the FIP tool's sources (through the variable FIPTOOLPATH) and the path to the FIP tool binary (through the variable FIPTOOL). See https://github.com/ARM-software/arm-trusted-firmware/blob/master/Makefile#L256-257

However, the FIP tool's sub-Makefile, i.e. tools/fip_create/Makefile, hard-codes the FIP tool's binary name through the variable PROJECT, overwriting any alternative name specified to the top-level Makefile. See https://github.com/ARM-software/arm-trusted-firmware/blob/master/tools/fip_create/Makefile#L31

The FIP tool's binary name should be propagated from the top-level Makefile to the tool's sub-Makefile. The top-level Makefile could export the FIPTOOL variable to the tool's sub-Makefile, which would define the variable PROJECT from it.

sandrine-bailleux-arm commented 8 years ago

Internal ref: http://jira.arm.com/browse/GENFW-1323