search

ARM-software / tf-issues

Issue tracking for the ARM Trusted Firmware project
37 stars 16 forks source link

Platform specific system counter register accessed from common code? #34

Closed mahamble closed 10 years ago

mahamble commented 10 years ago

Looks like common code in bl1 and bl31 access the platform specific system counter registers:

https://github.com/ARM-software/arm-trusted-firmware/blob/master/bl1/aarch64/bl1_arch_setup.c#L65

bl1/aarch64/bl1_arch_setup.c:

counter_base_frequency = mmio_read_32(SYS_CNTCTL_BASE + CNTFID_OFF);

https://github.com/ARM-software/arm-trusted-firmware/blob/master/bl31/aarch64/bl31_arch_setup.c#L66

bl31/aarch64/bl31_arch_setup.c:

counter_base_frequency = mmio_read_32(SYS_CNTCTL_BASE + CNTFID_OFF);

Looking at the A53 TRM the system counter interface (which I believe this code is accessing) is SOC specific so this interface should be moved to the platform?

sandrine-bailleux-arm commented 10 years ago

I believe this is already tracked by https://github.com/ARM-software/tf-issues/issues/24

mahamble commented 10 years ago

Ok, thanks. Do you know if it will be fixed in the coming 0.3 release?

danh-arm commented 10 years ago

It's not in the current set of in-flight patches but we can prioritize this straight after the release if it's hurting you.

mahamble commented 10 years ago

Yes please...

danh-arm commented 10 years ago

Fixed by https://github.com/ARM-software/arm-trusted-firmware/commit/1c297bf015226c182b66498d5a64b8b51c7624f5