search

ARM-software / trappy

This repository has moved to https://gitlab.arm.com/tooling/trappy
Apache License 2.0
60 stars 39 forks source link

ILinePlot: preserve order in the legend of ILinePlot #189

Closed JaviMerino closed 8 years ago

JaviMerino commented 8 years ago

In aa4bece3adc7 ("ILinePlot: don't call data_frame what's just a python dict") we turned a pd.Series to a dict, because we were effectively using it as a dict. However, there was a behaviour change as a result of this: pandas series preserve the order of entries whereas python dictionaries may reorder its entries. Use an OrderedDict instead, as that's what aa4bece3adc7 should have done.

JaviMerino commented 8 years ago

Reported by @deggeman

deggeman commented 8 years ago

Tested it. Works again!

sinkap commented 8 years ago

@deggeman Thanks for blessing this. @JaviMerino Thanks for the fix. Merging it! :+1: