search

ARM-software / trappy

This repository has moved to https://gitlab.arm.com/tooling/trappy
Apache License 2.0
60 stars 39 forks source link

ILinePlot: avoid generating plots that can hang the browser #203

Closed JaviMerino closed 8 years ago

JaviMerino commented 8 years ago

When creating huge plots, dygraph can make the browser choke. Prevent it by rasing an exception if the user is trying to create a plot that can hang their browser.

JaviMerino commented 8 years ago

@derkling and @jlelli rightfully complain that having to check whether the trace is too big before plotting is a pain. It's better to fail if ILinePlot is about to plot something that is too big and let the user override it if they are happy to wait.

sinkap commented 8 years ago

I am really sad this is needed and I am aware of this problem. I will try to get a handle on #103 as soon as possible since this seems to be bothering us often. Thanks for the fix to let the user be aware of the current limitations.

JaviMerino commented 8 years ago

I had forgotten about #103, I thought the problem was in dygraph. It's good that it's in our hands to improve the performance then!

JaviMerino commented 8 years ago

Merged as #205