Closed joelagnel closed 7 years ago
@derkling @bjackman @sinkap looks good to you?
Yep LGTM
Threw in the regex fix here too
Updated with few more fixes:
This PR remembered me we should add also some testcase to cover some example of possible android injected events.
Can you add a patch where you extend libs/trappy/tests/trace_systrace.html
with an example of each possible event we currently generate from user-space and correspondingly a test case which check we are parsing all the pid
, func
and data
fields as expected?
Added a few more test cases and fixed up some style comments.
@sinkap over to you. All changes requested are done
fixed last comment, good to go
Merged.
I promised @derkling I would write this so here you go.
Signed-off-by: Joel Fernandes joelaf@google.com