ARM-software / trappy

This repository has moved to https://gitlab.arm.com/tooling/trappy
Apache License 2.0
60 stars 39 forks source link

systrace: line test and regex fix #252

Closed joelagnel closed 7 years ago

joelagnel commented 7 years ago

I promised @derkling I would write this so here you go.

Signed-off-by: Joel Fernandes joelaf@google.com

joelagnel commented 7 years ago

@derkling @bjackman @sinkap looks good to you?

bjackman commented 7 years ago

Yep LGTM

joelagnel commented 7 years ago

Threw in the regex fix here too

joelagnel commented 7 years ago

Updated with few more fixes:

derkling commented 7 years ago

This PR remembered me we should add also some testcase to cover some example of possible android injected events.

Can you add a patch where you extend libs/trappy/tests/trace_systrace.html with an example of each possible event we currently generate from user-space and correspondingly a test case which check we are parsing all the pid, func and data fields as expected?

joelagnel commented 7 years ago

Added a few more test cases and fixed up some style comments.

joelagnel commented 7 years ago

@sinkap over to you. All changes requested are done

joelagnel commented 7 years ago

fixed last comment, good to go

sinkap commented 7 years ago

Merged.