Closed joelagnel closed 7 years ago
CC @sinkap
I'm happy for this to be merged... ASAP ;-)
@bjackman remark makes me suggesting one more time to s/conv_to_int/type_cast/
... which is much more generic as well as ready for future extension.
Ok. I reread your earlier comment and I agree with you now. Good idea. So, @sinkap @bjackman, I will call it type_cast
which we can expand in future to detect other types. We are indeed changing the type from string to possibly something else..
So I call it string_cast
with type type
as a parameter which makes it generic and handling only int
conversion for now. Also fixed the other comments. I think this should be good to go. @sinkap
And it's a goal! :+1:
Some speed enhancements, summarizing, altogether giving 30-35% improvement in performance: