trappy: 30% speed up goodies !!!

ARM-software / trappy

This repository has moved to https://gitlab.arm.com/tooling/trappy

Apache License 2.0

60 stars 39 forks source link

trappy: 30% speed up goodies !!! #256

Closed joelagnel closed 7 years ago

joelagnel commented 7 years ago

Some speed enhancements, summarizing, altogether giving 30-35% improvement in performance:

Optimize unique word search.
Optimize search for array pattern in data.
Optimize integer conversion in generate_data_dict.

joelagnel commented 7 years ago

CC @sinkap

derkling commented 7 years ago

I'm happy for this to be merged... ASAP ;-)

derkling commented 7 years ago

@bjackman remark makes me suggesting one more time to s/conv_to_int/type_cast/... which is much more generic as well as ready for future extension.

joelagnel commented 7 years ago

Ok. I reread your earlier comment and I agree with you now. Good idea. So, @sinkap @bjackman, I will call it type_cast which we can expand in future to detect other types. We are indeed changing the type from string to possibly something else..

joelagnel commented 7 years ago

So I call it string_cast with type type as a parameter which makes it generic and handling only int conversion for now. Also fixed the other comments. I think this should be good to go. @sinkap

sinkap commented 7 years ago

And it's a goal! :+1: