search

ARM-software / trappy

This repository has moved to https://gitlab.arm.com/tooling/trappy
Apache License 2.0
60 stars 39 forks source link

trappy/cache: Store the csv in utf-8 charset explicitly #287

Open credp opened 5 years ago

credp commented 5 years ago

When we load the files from trace-cmd output, we explicitly choose to load them using utf-8. This means we may have characters in our trace which cannot be represented in ascii, which makes pandas upset when we try to store the parsed dataframes in the csv cache.

This is not an issue for Python3 versions, as the to_csv method defaults to utf-8, whilst the Python2 to_csv method defaults to ascii.

Signed-off-by: Chris Redpath chris.redpath@arm.com

valschneider commented 5 years ago

Travis doesn't seem to like it, can you have a look as to why?