Fixed error when parsing android user mark

ARM-software / trappy

This repository has moved to https://gitlab.arm.com/tooling/trappy

Apache License 2.0

60 stars 39 forks source link

Fixed error when parsing android user mark #297

Closed Pablololo12 closed 1 year ago

Pablololo12 commented 5 years ago

I found out that when you use the Android tools to create trace markers from within the app, it doesn't recognize the PID of the app on the Trace.endSection() due to the regex. With this fix you can see when a trace marker ends.

douglas-raillard-arm commented 5 years ago

LGTM, waiting for an extra ack from @JaviMerino or @derkling

JaviMerino commented 5 years ago

I'm missing something. The unittest for tracing_mark_write in tests/test_systrace.py:79 doesn't expect the PID because the trace's end events don't have pids. Looking at the test trace, I see

surfaceflinger-594 ( 594) [002] ...1 538.785992: tracing_mark_write: E

Are you seeing something different? If so, can you add it to the test?