ARM-software / vscode-cmsis-csolution

Extension support for VS Code CMSIS Project Extension
https://marketplace.visualstudio.com/items?itemName=Arm.cmsis-csolution
Other
23 stars 5 forks source link

Does Build Clean really clean ? #21

Closed LMESTM closed 1 year ago

LMESTM commented 1 year ago

Not sure if this is a bug or a request for enhancement

Describe the bug

When pressing Clean Build button, it doesn't seem like clean really happens:

mcgordonite commented 1 year ago

Thanks @LMESTM, I am able to reproduce this issue. The clean build button isn't correctly passing the --rebuild option to cbuild. We'll get a fix out for this.

is cprj temp file removed ? If not, could this be considered ?

The CPRJ isn't removed by cbuild --rebuild. However, from toolbox 1.5.0 cbuild can run a build directly on a csolution without needing the intermediate CPRJ. We plan to update the extension to do this, so there would be no CPRJ to clean.

same for cmake files

This should be handled by correctly passing the --rebuild option to the underlying tools.

LMESTM commented 1 year ago

@mcgordonite thanks for confirmation and plan for correction - sounds good to me :-)

mcgordonite commented 1 year ago

Closing: the extension now passes --rebuild correctly when running a clean build.