ARMataTeam / ARMata

ARM template visualizer
MIT License
12 stars 4 forks source link

#63 resourece tree to list converter #67

Closed BienioM closed 6 years ago

BienioM commented 6 years ago

My proposition to fix #63

kamil-mrzyglod commented 6 years ago

Please run npm run lint to fix some code convention errors :) I'll update the readme file to provide some hints regarding contributions.

kamil-mrzyglod commented 6 years ago

Unfortunately it fails two tests:

` FAIL test/parsers/templateParser.spec.js ? parsers › templateParser › should connect resource and dependency

TypeError: Cannot read property 'name' of undefined

  at Object.it (test/parsers/templateParser.spec.js:127:47)
      at new Promise (<anonymous>)
  at Promise.resolve.then.el (node_modules/p-map/index.js:46:16)
      at <anonymous>
  at process._tickCallback (internal/process/next_tick.js:188:7)

FAIL test/reducers/fileDialog.spec.js ? reducers › fileDialog › should handle OPEN_FILE

expect(value).toMatchSnapshot()

Received value does not match stored snapshot 1.

- Snapshot
+ Received

@@ -1,11 +1,11 @@
 Object {
   "fileData": Object {
     "characters": 31,
     "contentVersion": undefined,
     "lines": 1,
-    "loadedIn": 0,
+    "loadedIn": 1,
     "outputs": Array [],
     "parameters": Array [],
     "resources": Array [],
     "schema": "",
     "variables": Array [],

  at Object.it (test/reducers/fileDialog.spec.js:11:205)
      at new Promise (<anonymous>)
  at Promise.resolve.then.el (node_modules/p-map/index.js:46:16)
      at <anonymous>
  at process._tickCallback (internal/process/next_tick.js:188:7)

`

while the second one we can mitigate, the first one has to be fixed.