search

ARMataTeam / ARMata

ARM template visualizer
MIT License
12 stars 4 forks source link

Fix visulization resources id #80

Closed BienioM closed 6 years ago

BienioM commented 6 years ago

I noticed that graph isn't working. The problem is with resource id, but I am not sure if my fix is correct. After added separator / graph starts working, but maybe the problem is somewhere inside TemplateParser.

kamil-mrzyglod commented 6 years ago

Could you post a template, which causes and error?

BienioM commented 6 years ago

https://github.com/Azure/azure-quickstart-templates/blob/master/101-vm-multiple-data-disk/azuredeploy.json

kamil-mrzyglod commented 6 years ago

Unfortunately this change breaks other templates, where dependencies are built using following syntax: [resourceId('Microsoft.Network/publicIPAddresses', variables('publicIPAddressName'))]

where in your example we have [concat('Microsoft.Network/publicIPAddresses/', variables('publicIPAddressName'))]

the real problem is how we treat resourceId function(which will be just "wiped out"). Maybe some change in this area would help. For know unfortunately this PR won't help.

BienioM commented 6 years ago

Ok, understand now.