search

ARMmbed / ATParser

Parser for AT commands and similar protocols.
35 stars 27 forks source link

Allow distinction between send and recv delimiters #8

Closed sarahmarshy closed 6 years ago

sarahmarshy commented 6 years ago

The mxchip EMW3080 is being ported to NSAPI (https://github.com/lizhibo32/mxchip-wifi-driver). This chip firmware requires '\r\n' to delimit AT commands sent to the radio, but the responses from the radio are delimited by only '\r'. This behavior is not supported by the current AT command parser. This PR adds support for this behavior.

sarahmarshy commented 6 years ago

@geky, I've pushed a change for your suggestion. Nice catch.

kjbracey commented 6 years ago

I think all 3 changes I've seen going past here recently are already in place in the ATCmdParser now in the mbed OS main tree. (For this case, it auto-detects recv line-endings, copying the code from stdio).

We should be deprecating this repository in favour of that.

geky commented 6 years ago

That's the sort of subtle behaviour change that's just going to hurt migration.

I'm not really sure what the next steps are for deprecating this repo. I guess updating porting documentation would be a start? That may be something for you to sync with @MarceloSalazar on.

kjbracey commented 6 years ago

Yep, had a bit of discussion with @sg- today too. Need to sort out documentation on FileHandle extensions including fdopen, ATCmdParser and UARTSerial, and then we can get on with marking Serial, Stream, ATParser and BufferedSerial deprecated.

sarahmarshy commented 6 years ago

@kjbracey-arm In the driver linked above, I tried to sub out the reference to ATParser in favor of ATCmdParser. After sorting out the compiler errors (attach->sigio, etc), it did not work. It requires further investigation, but, for now, it means that porting is non trivial.