ARMmbed / ble-nrf51822

Nordic stack and drivers for the mbed BLE_API
Other
46 stars 51 forks source link

Fix for compilation errors with S110 softdevice in btle.cpp #109

Closed ddavidebor closed 8 years ago

ddavidebor commented 8 years ago

Now methods that are exclusive to Softdevice S130 are not called when S110 (legacy mode) it's used.

This fix solves the following errors: -error: 'class nRF5xGattClient' has no member named 'characteristicDescriptorDiscoverer' -error: 'class nRF5xGattClient' has no member named 'discovery'

Compiled on ubuntu 14.04 with yotta on target mkit-gcc

ciarmcom commented 8 years ago

Automatic CI verification build not done, please verify manually.

ciarmcom commented 8 years ago

Automatic CI verification build not done, please verify manually.

ciarmcom commented 8 years ago

Automatic CI verification build not done, please verify manually.

ciarmcom commented 8 years ago

Automatic CI verification build not done, please verify manually.

ddavidebor commented 8 years ago

@zskdan we've fixed the same issue

zskdan commented 8 years ago

@ddavidebor sorry i didn't check before opening a pull request.

ddavidebor commented 8 years ago

No worries i should have updated the pool request sooner

pan- commented 8 years ago

Hi Davide,

I would be happy to merge your PR, but you have to sign our contributor licence agreements first: https://www.mbed.com/en/about-mbed/contributor-license-agreements/

Once this is done, I will merge it.

Thanks

bearsh commented 8 years ago

:laughing: for a 2 line contribution like this? this seems to much of bureaucracy...

ddavidebor commented 8 years ago

Fairly annoying, but i will send it as soon as possible.

pan- commented 8 years ago

Yes, we know, that it seems too much especially for such a tiny trivial fix. I'm sorry about this but contributor has to sign this agreement to have their contribution merged.

ddavidebor commented 8 years ago

Signed and sent, feel free to merge.

pan- commented 8 years ago

Thanks, I merge it.

ciarmcom commented 8 years ago

Automatic CI verification build not done, please verify manually.