search

ARMmbed / ble-nrf51822

Nordic stack and drivers for the mbed BLE_API
Other
46 stars 51 forks source link

Clash With Definition And Enum Naming #16

Closed jcady closed 9 years ago

jcady commented 9 years ago

See: mbedmicro/BLE_API#46

jcady commented 9 years ago

I just discovered there's also a file naming clash with the BLE API. Trying to include "BLE.h" leads to problems because there's also a BLE.h in nrf51822.

rgrover commented 9 years ago

this is a duplicate of https://github.com/mbedmicro/BLE_API/issues/46 the problem needs to be fixed in nRF51822, not in BLE

rgrover commented 9 years ago

regarding duplicate BLE.h: the include of BLE.h from BLE_API should be done like:

#include "ble/BLE.h"

I need to propagate this new include format to all demos.

jcady commented 9 years ago

I did find one more problem. There's another naming clash in UARTService.h.

Static const here:

https://github.com/mbedmicro/BLE_API/blob/master/ble/services/UARTService.h#L44

Define here:

https://github.com/mbedmicro/nRF51822/blob/develop/nordic-sdk/components/softdevice/s130/include/ble_gatt.h#L50

Same problem, compiler complains of expected identifier.