Remove unnecessary 'compiler_abstraction.h' to get rid of duplicate '…

ARMmbed / ble-nrf51822

Nordic stack and drivers for the mbed BLE_API

Other

46 stars 51 forks source link

Remove unnecessary 'compiler_abstraction.h' to get rid of duplicate '… #23

Closed adfernandes closed 9 years ago

adfernandes commented 9 years ago

The compiler_abstraction.h header is unnecessary here because mbed/libraries/mbed/targets/cmsis/core_cm0.h already abstracts out the __ASM definition.

If the file is included, you get a warning: "__ASM" redefined warning.

The specific files are

nRF51822/source/nordic-sdk/components/drivers_nrf/hal/compiler_abstraction.h and
mbed/libraries/mbed/targets/cmsis/core_cm0.h

rgrover commented 9 years ago

Pulled into the develop branch. will hit 'master' with the next release. Thanks.

adfernandes commented 9 years ago

This second pull request changes the DiscoveredCharacteristic API to have getUUID() as opposed to only getShortUUID(). Otherwise you can't have long-UUID characteristics... :smile: It needs the corresponding pull request in BLE_API.

adfernandes commented 9 years ago

Added the latest patch because service UUIDs only matched the short, for some reason - I'm guessing that that's a historic artifact... :smile:

Took me forever to find this because I didn't realize that the UUID class takes big-endian byte arrays in the constructor... I'm so used to writing them out in little-endian form that I have scripts that do it for me!

rgrover commented 9 years ago

Pulled into the develop branch. Matching against shortUUIDs was indeed a historic artifact. Thanks so much!