ARMmbed / ble-nrf51822

Nordic stack and drivers for the mbed BLE_API
Other
46 stars 51 forks source link

Error check number of characteristics #48

Closed Timmmm closed 8 years ago

Timmmm commented 8 years ago

Currently it just blindly writes beyond the end of the array, leading to impossible-to-find bugs.

It doesn't help that the limit on the number of characteristics doesn't seem to be documented anywhere.

Sorry github's editor won't let me use spaces so there may be some correct indentation characters in there (i.e. tabs!). I did try.

miklis commented 8 years ago

Automatic CI verification build not done, please verify manually.

rgrover commented 8 years ago

thanks for contributing. this is good sanity checking. I'll review this more carefully shortly. Looks good based on an initial glance.

Timmmm commented 8 years ago

Thanks!