Closed LiyouZhou closed 8 years ago
thakns for this pull request. I'll review this shortly.
all this looks good to me. Since we've incorporated some changes to pstorage, it would be nice if we could re-test with the URI_Beacon (or any other demo which tries to use persistent storage). I'll defer to @andresag01 for his OK. Let's try to avoid changes which add warning messages. Thanks @LiyouZhou
could you also confirm that we don't need to update our softdevice hex files to match this new SDK? I believe we're already taking our softdevice from SDK8.1, but I could be wrong about that.
@rgrover @LiyouZhou : The softdevice files we are using are these ones. I am not sure how the versioning works but the file names say:
@LiyouZhou please check if we could benefit from a different softdevice from SDKv8.1.
@LiyouZhou could you please also review the release notes for v8.1 of the Nordic SDK to help clarify what benefits exist in upgrading to it? We will be upgrading the Nordic SDK over time, but we should try to document any major benefits at each upgrade step--if such benefits exist.
@rgrover I have just tried the URIBeacon demo in ble-examples and it seems to behave as expected i.e. I am able to connect, configure something. Then when I reset the device my configuration is retained, I assume because it was saved in permanent storage.
ok. I'm satisfied with our upgradability to v8.1 of the SDK. I'd just like confirmation about the softdevice hex file.
@rgrover I can confirm current headers are from s130_nrf51_1.0.0 softdevice. Softdevice have some definition changes, be I see no obvious performance benefit. I would like to keep the softdevice upgrade a separate effort as it needs more thought and investigation. S130v2 is at alpha release stage and may not be fully compatible with sdk 8.1.
@rgrover Here are some benefits from the sdk v8.1 release notes:
it all seems good to me. I'll go ahead with v8.1
@rgrover @andresag01 Please review.