search

ARMmbed / ble-nrf51822

Nordic stack and drivers for the mbed BLE_API
Other
46 stars 51 forks source link

Fix for GCC lost in SDK v8.0 update #8

Closed rosterloh closed 9 years ago

rosterloh commented 9 years ago

This fix was previously in the library but was lost when porting over to new SDK

0xc0170 commented 9 years ago

where was this fixed, in mbed sources or in sources coming from nordic?

rosterloh commented 9 years ago

It was fixed in this library. The nrf_svc.h file had it in but was not in the Nordic sources

0xc0170 commented 9 years ago

As I understand, it should be reported to them, not to override this fix again in the future.

rosterloh commented 9 years ago

I just though I might submit it here as it was in before and no one who uses this library with mbed when they export to local compiler will be able to build.

0xc0170 commented 9 years ago

@rosterloh Yes, correct. My point was that we should report this type of bugs (along with fixing them locally) directly to the file owners. @rgrover will look at this PR