Fixed endianness bug in nRF5xServiceDiscovery::processDiscoverUUIDResponse so it is consistent with BLE API.

ARMmbed / ble-nrf51822

Nordic stack and drivers for the mbed BLE_API

Other

46 stars 51 forks source link

Closed marcuschangarm closed 8 years ago

marcuschangarm commented 8 years ago

In BLE::UUID, uuids are stored and handled little endian. This PR preserves the endianness returned by the Nordic Softdevice during discovery.

rgrover commented 8 years ago

@pan- please comment on this.

marcuschangarm commented 8 years ago

@pan- any comments to the PR, not the original code?

pan- commented 8 years ago

I'm not sure to understand, I'm talking about the PR, it can be improved if memcpy is used instead of for loop. Beside that, I'm happy with it.

marcuschangarm commented 8 years ago

I didn't put in the for-loop. If you want it removed, open an issue or make a pull request.