search

ARMmbed / ble-nrf51822

Nordic stack and drivers for the mbed BLE_API
Other
46 stars 51 forks source link

Add -Wno-unused-function to supress-warnings.cmake #83

Closed andresag01 closed 8 years ago

andresag01 commented 8 years ago

@rgrover @LiyouZhou

LiyouZhou commented 8 years ago

@andresag01 These warnings come from nordic files or our files? If it is our files, can't we fix the sourcefile? if it is nordic, does it work if we put this cmake file in nrf51-module?

andresag01 commented 8 years ago

They come from the nordic files, but they are included by our files. We already introduced some additional fixes for the nordic files as well. Have a look at this PR

rgrover commented 8 years ago

This looks good to me. +1

To answer LiYou: In many cases, the problems originate from headers in the nordic SDK, but then manifest when these headers are included in sources from ble-nrf51822 (or elsewhere).

rgrover commented 8 years ago

@LiyouZhou bump

rgrover commented 8 years ago

oh no, this was merged into 'master' :( it should have gone into 'develop'

rgrover commented 8 years ago

I've deleted this merge from the history

rgrover commented 8 years ago

merged into develop. published ble-nrf51822-2.2.2