search

ARMmbed / ble-nrf51822

Nordic stack and drivers for the mbed BLE_API
Other
46 stars 51 forks source link

V10 helper func #97

Open LiyouZhou opened 8 years ago

LiyouZhou commented 8 years ago

Replace helper functions provided by ble-nrf51822 with ones provided by nordic sdk v10. Depends on https://github.com/ARMmbed/nrf51-sdk/pull/13.

@pan- Please review.

LiyouZhou commented 8 years ago

bump

pan- commented 8 years ago

I didn't forgot about these, it is just that I need time to analyze what is going on on the previous implementation and the new one. I will close this soon

ghost commented 8 years ago

how's this gonna go now that there's an nrf52 sdk module?

ciarmcom commented 8 years ago

Automatic CI verification build not done, please verify manually.

pan- commented 8 years ago

NRF52 doesn't change anything, the Nordic SDK still exist, softdevice still exist and NRF51 still exist. Nordic has made a nice work to make SDK v10 and SDK v11 compatible. It should not be an issue.

ghost commented 8 years ago

sure, but there's a direct dependency on the nrf51 sdk yotta module, but no dependency on the nrf52-sdk yotta module

pan- commented 8 years ago

The nrf52 port is far from ready at the moment. Later, I think we will have an nrf-sdk repository which encompass nordic SDK for nrf51 and nrf52. There is no difference between these two. At some point, I also think that this repository (ble-nrf51822) will become ble-nrf5X and will be used by nrf51 and nrf52 platform.

LiyouZhou commented 8 years ago

@pan- What is your plan for this?

pan- commented 8 years ago

I won't merge it now, I need time to understand all the implications of this change. But I did not forget about it.