ARMmbed / ble-x-nucleo-idb0xa1

port of BLE_API to ST BLE shield
14 stars 5 forks source link

Module out-of-date in yotta registry? #5

Closed andresag01 closed 8 years ago

andresag01 commented 8 years ago

It seems that this module is out-of-date in the yotta registry. As a result it cannot be directly used to build the BLE examples. I get errors like the following:

/repos/ble-examples/BLE_EddystoneService/yotta_modules/x-nucleo-idb0xa1/source/BlueNRGGattServer.cpp.o -c /Users/andama01/Documents/repos/ble-examples/BLE_EddystoneService/yotta_modules/x-nucleo-idb0xa1/source/BlueNRGGattServer.cpp
/Users/andama01/Documents/repos/ble-examples/BLE_EddystoneService/yotta_modules/x-nucleo-idb0xa1/source/BlueNRGGattServer.cpp: In member function 'virtual ble_error_t BlueNRGGattServer::addService(GattService&)':
/Users/andama01/Documents/repos/ble-examples/BLE_EddystoneService/yotta_modules/x-nucleo-idb0xa1/source/BlueNRGGattServer.cpp:199:97: error: 'class GattAttribute' has no member named 'getInitialLength'
         if ((p_char->getValueAttribute().getValuePtr() != NULL) && (p_char->getValueAttribute().getInitialLength() > 0)) {
                                                                                                 ^

But it seems the issue has been fixed in this repository, see here

rgrover commented 8 years ago

Is this an issue of publishing the latest of the module?

apalmieriGH commented 8 years ago

The module has been updated in the public repository ble-x-nucleo-idb0xa1 Who is in charge of publishing in the yotta registry?

andresag01 commented 8 years ago

@rgrover: If I clone this repo and manually link the module it builds. The one that yotta automatically pulls in from the registry seems to fail the build stage.

apalmieriGH commented 8 years ago

@andresag01 @rgrover @betzw : Commit 1919996 just published to yotta registry

rgrover commented 8 years ago

@andresag01 could you please try this?

rgrover commented 8 years ago

we now have a successful build using the latest of this module. :+1:

andresag01 commented 8 years ago

@apalmieriGH: Thanks for fixing, this works now

apalmieriGH commented 8 years ago

why the module automatically pulled from the yt registry is still outdated even after I published it?

rgrover commented 8 years ago

did you publish to the public registry? Have you done a yt update?

apalmieriGH commented 8 years ago

yes, but the module dependency within ble/module.json needs to be updated:

"x-nucleo-idb0xa1": "^2.0.1"
rgrover commented 8 years ago

^2.0.1 means >= 2.0.1 and < 3.0.0

apalmieriGH commented 8 years ago

ok, so also 2.0.0 should be fine. Thanks.

rgrover commented 8 years ago

no, 2.0.0 is not within >= 2.0.1 and < 3.0.0

apalmieriGH commented 8 years ago

ok, sorry for misunderstanding the semantic versioning. anyway, the latest published version is:

^2.0.1

please, update the ble/module.json accordingly.

rgrover commented 8 years ago

module.json in ble says that it needs ^2.0.0 of your library as a target dependency. If you've released v2.0.1, then that should be picked up automatically. Nothing needs to change in ble's module.json until you jump to v3.0 of your module. I don't see what you need here.

apalmieriGH commented 8 years ago

ok, ^2.0.0 is fine.