BLE.h conflict with Nordic SDK ble.h

ARMmbed / ble

API to abstract working with Bluetooth Smart Controllers

Other

80 stars 75 forks source link

BLE.h conflict with Nordic SDK ble.h #177

Closed aracosta1 closed 7 years ago

aracosta1 commented 8 years ago

On case insensitive filesystems (Windows first) the two name collide and so often compilation fails because the compiler choose the first of the two file it find in its search path order.

This create big problem when tring to export from mbed online environment to offline build tools like EmBlock or other.

Is it possible to change the mane to something else like BLE_api.h or similar ?

pan- commented 8 years ago

Hi,

We all agree that it is not pretty atm. but normally, name should not collides:

BLE.h from the ble module is included by the directive: #include <ble/Ble.h>
ble.h from the nrf51-sdk module is included by the directive #include <ble.h>

ciarmcom commented 8 years ago

ARM Internal Ref: IOTSFW-2094

aracosta1 commented 8 years ago

I have seen his problem exporting to Em:block. The problem is the include statement in the nRF51822 code because it does not specify a path so it includes the first ble.h it found in the search path order the is the one from ble_api. I know the correct place to make changes should be the sdk, I'll try to raise the issue on the nRF51822 repository

0xc0170 commented 8 years ago

This was reported on forum.mbed.com, and there was a reference to gcc4mbed, they had the same problem: http://forums.mbed.com/t/error-mbed-nordic-semi-ble-includes-algorithm-into-c-files/1110

pan- commented 8 years ago

I think this issue has been solved with: https://github.com/ARMmbed/nrf51-sdk/pull/26 which is included in nrf51-sdk version 2.4.0. @aracosta1 Could you comment on that ?