search

ARMmbed / ci-test-shield

mbed CI Test Shield
Apache License 2.0
9 stars 36 forks source link

Added conconcurrent testing #62

Closed brandonboesch closed 7 years ago

brandonboesch commented 7 years ago

GPIO test runs DIO, AnalogIn, and InterruptIn sequentially in one test case.

0xc0170 commented 7 years ago

This module (this patch) should follow the mbed style guideline. We should align it.

Plus where is this test described what it does, what's expected output?

brandonboesch commented 7 years ago

@0xc0170 , I didn't know there was an mbed style guideline, can you point me to that? Also, where are we supposed to be documenting what the test is doing, and the expected output? Thanks.

0xc0170 commented 7 years ago

I didn't know there was an mbed style guideline, can you point me to that?

https://docs.mbed.com/docs/mbed-os-handbook/en/latest/cont/code_style/

Also, where are we supposed to be documenting what the test is doing, and the expected output?

I believe for this one we will need to start doing it. We got few cases in mbed OS where above the test case, we describe the test (what is testing) in the comments

screamerbg commented 7 years ago

LGTM. @brandonboesch thanks for this! Please check @mray19027's comments.