search

ARMmbed / ci-test-shield

mbed CI Test Shield
Apache License 2.0
9 stars 36 forks source link

Removing SDDriver #81

Closed naveenkaje closed 5 years ago

naveenkaje commented 5 years ago

Mbed OS now has block device driver code. No need for carrying this as a library. This change will resolve linking errors as seen here

Built with: 
mbed test -n tests-api-spi

Linking Error:
BUILD/tests/K64F/GCC_ARM/mbed-os/components/storage/blockdevice/COMPONENT_SD/SDBlockDevice.o: In function `mbed::SPI::~SPI()':
C:\mbed-cli\ci-test-shield.git/./mbed-os/platform/Callback.h:906: multiple definition of `SDBlockDevice::deinit()'
BUILD/tests/K64F/GCC_ARM/SDDriver/features/filesystem/sd/SDBlockDevice.o:C:\mbed-cli\ci-test-shield.git/.\SDDriver\features\filesystem\sd/SDBlockDevice.cpp:260: first defined here
BUILD/tests/K64F/GCC_ARM/mbed-os/components/storage/blockdevice/COMPONENT_SD/SDBlockDevice.o: In function `BlockDevice::sync()':...
kegilbert commented 5 years ago

@screamerbg (assuming you're the owner of this repo, wasn't 100% on that)

screamerbg commented 5 years ago

@c1728p9 Please review

maclobdell commented 5 years ago

fixed by #88