search

ARMmbed / ci-test-shield

mbed CI Test Shield
Apache License 2.0
9 stars 36 forks source link

Remove mbed wait deprecated API usage #96

Closed rajkan01 closed 4 years ago

rajkan01 commented 4 years ago

wait and wait_ms are removed from Mbed OS source in the PR#12572, so modified source to use thread_sleep_for API.

Reviewers

@evedon, @maciejbocianski, @jamesbeyond

jeromecoutant commented 4 years ago

Hi What about ?

    [Error] Comms.cpp@117,31: no member named 'gettid' in 'rtos::Thread'
    [Error] Mixed.cpp@188,31: no member named 'gettid' in 'rtos::Thread'
jamesbeyond commented 4 years ago

Hi What about ?

    [Error] Comms.cpp@117,31: no member named 'gettid' in 'rtos::Thread'
    [Error] Mixed.cpp@188,31: no member named 'gettid' in 'rtos::Thread'

Thanks for pointing out, more fixings are on the way

evedon commented 4 years ago

Could you update Thread::gettid as well ? it has been deprecated in ARMmbed/mbed-os#12142 change Thread::gettid to ThisThread::get_id should work.

We will do this in a different PR.

jamesbeyond commented 4 years ago

We will do this in a different PR. I created one: I https://github.com/ARMmbed/ci-test-shield/pull/97 This PR need to rebase after it been merged

jeromecoutant commented 4 years ago

Let's merge this one ?

jamesbeyond commented 4 years ago

Let's merge this one ?

This PR will need https://github.com/ARMmbed/ci-test-shield/pull/98 to be merged first

jamesbeyond commented 4 years ago

can you rebase @rajkan01