search

ARMmbed / connectedhomeip

Project Connected Home over IP is a new Working Group within the Zigbee Alliance. This Working Group plans to develop and promote the adoption of a new connectivity standard to increase compatibility among smart home products, with security as a fundamental design tenet.
https://www.connectedhomeip.com
Apache License 2.0
10 stars 4 forks source link

Mbed os cleanup #161

Closed ATmobica closed 3 years ago

ATmobica commented 3 years ago

Problem

Reference issue: #139

Summary of Changes

Remove install mbed-os to /opt directory Cleanup chip-build-vscode docker image Set MBED_OS_PATH variable in mbed_example.sh instead of override

I rebuilt mbed-os docker locally and checked that python requirements from mbed-os are not necessary to build our applications.

lukgni commented 3 years ago

Is this PR still valid or it is outdated?

ATmobica commented 3 years ago

It is rather outdated. But we probably still need some mbed-os cleanup after switching to third_party mbed-os and the latest version

pan- commented 3 years ago

@lukgni The change was OK for me and I would merge it if the removal of pip3 install --no-cache-dir -r /opt/mbed-os/requirements.txt is double checked. Can you look at this ?

lukgni commented 3 years ago

@pan- Sure, I will take care of that.

ATmobica commented 3 years ago

This PR is no longer valid. We will do the cleanup directly on the upstream docker image version. It contains part of the fixes from this PR. We just need to remove the Mbed OS sources and toolchain from it.