search

ARMmbed / core-util

DEPRECATED: Mbed 3 utilities library
Other
12 stars 17 forks source link

Fixes to Array class #73

Closed adbridge closed 8 years ago

adbridge commented 8 years ago

Add default initialisers in the Array constructor for internal parameters This fixes github issue 67

Added a test to the push_back() method to check that the init() method has previously been invoked before allowing elements to be added. This fixes github issue 71

adbridge commented 8 years ago

@bogdanm @0xc0170 Code changes

0xc0170 commented 8 years ago

@adbridge Please edit the commit message, it was not updated to the latest change to this change-set

adbridge commented 8 years ago

@0xc0170 I don't understand your last comment: The commit message says this:

Add default initialisers in the Array constructor for internal parame… … adbridge committed 5 days ago

…ters.

This fixes github issue 67

Added a test to the push_back() method to check that the init() method has previously been invoked before allowing elements to be added. This fixes github issue 71

Which is the correct commit message ?

0xc0170 commented 8 years ago

@0xc0170 I don't understand your last comment: The commit message says this:

the commit message - Added a test - I understood this one refers to previous test implementation which was part of this PR. I see now that it refers to additional check in the implementation, which I misunderstood. A tip: You can use #67 for instance to reference the issue (creates a link).

0xc0170 commented 8 years ago

@bogdanm Pls review

bogdanm commented 8 years ago

LGTM, +1. This is the least we can do for now.