ARMmbed / homebrew-formulae

homebrew ("the missing package manager for OS X") formulae from the mbed team.
Apache License 2.0
126 stars 39 forks source link

Fix 6-2016-q4-major version #13

Closed niklarm closed 7 years ago

niklarm commented 7 years ago

This version isn't an update, it's a major release.

I'm not sure how to fix this, rebasing and force pushing master would likely create issues with brew update.

Ideas? cc @hugovincent @Patater @AlessandroA

Patater commented 7 years ago

Does something motivate this change other than cosmetics? I'm tempted to leave it saying "update" incorrectly, to avoid breaking people. We can make the version string correct for the next update (or major).

niklarm commented 7 years ago

Yes, just leaving it is best I think. We'd be adding a "new" version with this commit, that isn't different.

I actually find the suffix kinda redundant anyways. The version number makes it pretty obvious anyways. I'd be in favor of dropping the -major/-update suffix completely.

Patater commented 7 years ago

I would like to leave the suffix in for future updates and majors, so we match the official version naming convention.