Closed niklarm closed 7 years ago
Does something motivate this change other than cosmetics? I'm tempted to leave it saying "update" incorrectly, to avoid breaking people. We can make the version string correct for the next update (or major).
Yes, just leaving it is best I think. We'd be adding a "new" version with this commit, that isn't different.
I actually find the suffix kinda redundant anyways. The version number makes it pretty obvious anyways. I'd be in favor of dropping the -major
/-update
suffix completely.
I would like to leave the suffix in for future updates and majors, so we match the official version naming convention.
This version isn't an update, it's a major release.
I'm not sure how to fix this, rebasing and force pushing master would likely create issues with
brew update
.Ideas? cc @hugovincent @Patater @AlessandroA