Make issue for RZ_A1H

[Osamu-Nakamura]

I tried to make jerryscript for RZ_A1H that is mbed os 5 compliant platform by invoking the command _make BOARD=RZA1H. However, I faced the following error:

$ make BOARD=RZ_A1H
python ../tools/js2c.py --ignore pins.js
python tools/generate_pins.py RZ_A1H
Traceback (most recent call last):
  File "tools/generate_pins.py", line 176, in 
    pins = enumerate_pins(pins_file, ['./tools'] + list(includes), defines)
  File "tools/generate_pins.py", line 133, in enumerate_pins
    return v.visit(ast)
  File "tools/generate_pins.py", line 86, in visit
    value = value or self.visit(c)
  File "tools/generate_pins.py", line 86, in visit
    value = value or self.visit(c)
  File "tools/generate_pins.py", line 82, in visit
    value = self.visit_TypeDecl(node)
  File "tools/generate_pins.py", line 110, in visit_TypeDecl
    pins[pin.name] = evaluator.eval(expr.strip())
  File "C:\Python27\lib\site-packages\simpleeval.py", line 245, in eval
    return self._eval(ast.parse(expr.strip()).body[0].value)
IndexError: list index out of range

It seems that the cause of the above error is PinNames.h implementation for RZ_A1H. The current implementation is described below:

typedef enum {
    P0_0 = 0,
          P0_1, P0_2, P0_3, P0_4, P0_5,_P0_6,_P0_7,_P0_8,_P0_9,_P0_10,_P0_11,_P0_12,_P0_13,_P0_14,_P0_15,
    P1_0, P1_1, P1_2, P1_3, P1_4, P1_5, P1_6, P1_7, P1_8, P1_9, P1_10, P1_11, P1_12, P1_13, P1_14, P1_15, 
    P2_0, P2_1, P2_2, P2_3, P2_4, P2_5, P2_6, P2_7, P2_8, P2_9, P2_10, P2_11, P2_12, P2_13, P2_14, P2_15, 
    P3_0, P3_1, P3_2, P3_3, P3_4, P3_5, P3_6, P3_7, P3_8, P3_9, P3_10, P3_11, P3_12, P3_13, P3_14, P3_15, 
    P4_0, P4_1, P4_2, P4_3, P4_4, P4_5, P4_6, P4_7, P4_8, P4_9, P4_10, P4_11, P4_12, P4_13, P4_14, P4_15, 
    P5_0, P5_1, P5_2, P5_3, P5_4, P5_5, P5_6, P5_7, P5_8, P5_9, P5_10, P5_11, P5_12, P5_13, P5_14, P5_15, 
    P6_0, P6_1, P6_2, P6_3, P6_4, P6_5, P6_6, P6_7, P6_8, P6_9, P6_10, P6_11, P6_12, P6_13, P6_14, P6_15, 
    P7_0, P7_1, P7_2, P7_3, P7_4, P7_5, P7_6, P7_7, P7_8, P7_9, P7_10, P7_11, P7_12, P7_13, P7_14, P7_15, 
    P8_0, P8_1, P8_2, P8_3, P8_4, P8_5, P8_6, P8_7, P8_8, P8_9, P8_10, P8_11, P8_12, P8_13, P8_14, P8_15, 
    P9_0, P9_1, P9_2, P9_3, P9_4, P9_5, P9_6, P9_7, P9_8, P9_9, P9_10, P9_11, P9_12, P9_13, P9_14, P9_15, 
    P10_0,P10_1,P10_2,P10_3,P10_4,P10_5,P10_6,P10_7,P10_8,P10_9,P10_10,P10_11,P10_12,P10_13,P10_14,P10_15,
    P11_0,P11_1,P11_2,P11_3,P11_4,P11_5,P11_6,P11_7,P11_8,P11_9,P11_10,P11_11,P11_12,P11_13,P11_14,P11_15,

*snips* 

If enum value is NOT explicitly specified as shown above, the error occurs when generating pins.cpp. Is there any option for avoiding this error without revising pinNames.h? I think there is no issue in the above pinNames.h implementation from C language's point of view and therefore, jerryscript should be built for RZ_A1H successfully without the modification.

If you could give me any comment, it would be very helpful to me.

[matthewelse]

Hi, I believe that this is an error with the way that we're evaluating the enum values. We should probably change the implementation of generate_pins.py to follow the way that C/C++ does it.

[Osamu-Nakamura]

Thank you for your comment. Until generate_pins.py would be updated, I would modify pinNames.h so that generate_pins.py can generate pins.cpp. I look forward to the change.