ARMmbed / mbed-cli

Arm Mbed Command Line Interface
https://os.mbed.com
Apache License 2.0
333 stars 176 forks source link

Mbed-os version updated to unrecognized number automatically during publish operation performed from application #289

Closed TaniaMirzin closed 8 years ago

TaniaMirzin commented 8 years ago

@jenia81 @screamerbg

Reproducing steps:

  1. Import https://github.com/ARMmbed/training-provisioning-release application.
  2. The mbed-os.lib version should be https://github.com/ARMmbed/mbed-os/#f4790ce69f273f5138ff23bf628bbe0e3a62b9d2.
  3. Perform publish (without any additional steps). Messages during the publish: [mbed] Checking for local modifications... |[mbed] Updating reference "mbed-os/features/FEATURE_CLIENT/mbed-client-classic" -> "https://git@github.com/ARMmbed/mbed-client-classic/#30260f355273100e9a2de47e26502d7b6ebe2f33" -[mbed] Updating reference "mbed-os/features/FEATURE_IPV6/nanostack-hal-mbed-cmsis-rtos" -> "https://git@github.com/ARMmbed/nanostack-hal-mbed-cmsis-rtos/#36968fc133c74cb43d95588ae324623fe0d20f78" /[mbed] Updating reference "mbed-os/features/FEATURE_IPV6/sal-stack-nanostack-private" -> "https://git@github.com/ARMmbed/sal-stack-nanostack-private/#5d3365ce7df303b31d88bdddf08d296088edd24d" -[mbed] Updating reference "mbed-os" -> "https://git@github.com/ARMmbed/mbed-os/#f4790ce69f273f5138ff23bf628bbe0e3a62b9d2" [mbed] Uncommitted changes in library "mbed-os" in "/sharedhome/tanmir01/provisioning/out/k64f_mbedos_gnuc-release_package/training-provisioning-release/mbed-os" Press enter to commit and publish: [mbed] Updating reference "mbed-os" -> "https://git@github.com/ARMmbed/mbed-os/#d7eddf0f43c7746b15bc0832ad3e4df6f4ab445a" [mbed] Uncommitted changes in library "training-provisioning-release" in "/sharedhome/tanmir01/provisioning/out/k64f_mbedos_gnuc-release_package/training-provisioning-release" Press enter to commit and publish: [mbed] Pushing local repository "training-provisioning-release" to remote "ssh://git@github.com/ARMmbed/training-provisioning-release.git"

The result of current publish operation is changing of mbed-os version to d7eddf0f43c7746b15bc0832ad3e4df6f4ab445a,when the publish itself was empty (without any changes). Expected behavior: mbed-os version should not be changes. This behavior wasn't detected with previous cli versions.

screamerbg commented 8 years ago

@TaniaMirzin Can you try mbed CLI from this PR https://github.com/ARMmbed/mbed-cli/pull/290 ? First uninstall any existing mbed CLI via pip uninstall mbed-cli Then clone my fork - https://github.com/screamerbg/neo And finally inside the cloned folder run python setup.py install, which might require sudo on Linux/Mac

TaniaMirzin commented 8 years ago

@jenia81 @screamerbg When i installed mbed-cli from your fork i updated to version 0.8.3. As i can see PR #290 is already merged to the main tree and its version 0.8.8, so i worked with it and not with 0.8.3. I tried to perform the same steps and the bug is still reproducing. I see also problem of recognizing added files during publish operation. The problem can be reproduced after steps 1-3.

TaniaMirzin commented 8 years ago

@jenia81 @screamerbg mbed-cli 0.8.8 Version resolved the described issues. Thansk.