Coap option tidy - Githubissues

ARMmbed / mbed-client-c

DEPRECATED: Coap+mbed-client-c libraries.

https://cloud.mbed.com/docs/current

Other

2 stars 11 forks source link

Coap option tidy #75

Closed AnttiKauppila closed 8 years ago

AnttiKauppila commented 8 years ago

Changes made: NOTE: This will cause major break, because variable types have been changed!

Created a new sn_nsdl_put_resource function, which takes ownership of sn_nsdl_resource_info_s resource object (not members) instead of creationg copy of it
Rearranged struct member variable to pack better into memory
Refactored coap_options_list to treat number members as numbers instead of strings
Unittests updated to reflect new changes

mbed-ci commented 8 years ago

Automatic CI verification build not done, please verify manually.

AnttiKauppila commented 8 years ago

@kjbracey-arm @yogpan01 @anttiylitokola @terhei @mikter Please could you Kevin check this change. Added others here (you can review too!), because there will be PR for mbed-client and coap-service when this gets in.

AnttiKauppila commented 8 years ago

Compilation will fail because of API breaks.

yogpan01 commented 8 years ago

@AnttiKauppila You need to create PRs for mbed-client and coap-service ASAP because all this have to go into mbed-os at the same time otherwise the whole mbed-os will be broken , if they are not going in same PR.

anttiylitokola commented 8 years ago

I ran the our connector suite (200 testcases) locally with these changes and no issues found.

kjbracey commented 8 years ago

Ideally the unit test changes and bug fixes would be split and then squashed into the corresponding original patches - this is a non-bisectable series. But I guess that's too advanced.

Might be worth looking into the comment about NSDL-C in the Content-Format patch. I can't remember exactly what the issue was, but it may have been something like "don't bother putting Content-Format in if it's text/plain", which is wrong according to final CoAP specs.