ARMmbed / mbed-client-example-6lowpan

DEPRECATED: Example demonstrating 6LoWPAN mesh networking
https://cloud.mbed.com/docs/current
Other
19 stars 13 forks source link

README says to edit file in yotta_modules directory #6

Closed bridadan closed 9 years ago

bridadan commented 9 years ago

This line instructs the user to edit a source file in /yotta_modules: https://github.com/ARMmbed/mbed-client-example-6lowpan/blame/9ae9e19f2fed2044d56aa3977c054f47c2e5271b/README.md#L71

I've been told in the past that we are highly discouraging this, so this should probably be removed. Is there a way to break out this functionality in a function or something?

artokin commented 9 years ago

Unfortunately network configuration API is not yet available and we do not want to introduce temporary API for configuration. Current solution is not nice, but I believe configuration should be done with the right API once it is available.

0xc0170 commented 9 years ago

@bridadan valid point :+1:

We got a solution to this - "yotta link" command to do this job - clone, edit, link and build. I can't find some guidance for this in the yotta docs, at least this comment provides some: https://github.com/ARMmbed/yotta/issues/276#issuecomment-115622327

bogdanm commented 9 years ago

This really needs to be fixed. Editing files in yotta_modules/ is a no-no, our documentation should reflect that.

bridadan commented 9 years ago

Please excuse my little knowledge of 6lowpan and mesh networks in general, but maybe the right attribute needs to be broken out somewhere in here? https://github.com/ARMmbed/mbed-mesh-api/blob/7296eb29e04b634026b981a0149d0b661954960a/mbed-mesh-api/AbstractMesh.

artokin commented 9 years ago

Readme has been updated to use "yotta link" instead of modifying code in yotta_module.

0xc0170 commented 9 years ago

For reference: #9

@bridadan I believe this can be closed