search

ARMmbed / mbed-flasher

mbed device flasher application
Other
10 stars 10 forks source link

Platform specific file copying #145

Closed juhhov closed 5 years ago

juhhov commented 6 years ago

Status

READY

Description

Revert back to platform specific file copying as the current implementation is not robust.

In non windows platforms file is now created with flags: os.O_CREAT | os.O_TRUNC | os.O_RDWR | os.O_SYNC with the exception of arm machines which stay: os.O_CREAT | os.O_TRUNC | os.O_RDWR | os.O_DIRECT

http://man7.org/linux/man-pages/man2/open.2.html

https://jira.arm.com/browse/IOTSYSTOOL-1290

YifeiZuo01 commented 6 years ago

add Jira link to PR desciption?

jupe commented 6 years ago

why py3 fails?

RomanSaveljev commented 5 years ago

the current implementation is not robust

Once this change is in, what is the plan to measure whether the system is more robust.. less robust.. same robust?

juhhov commented 5 years ago

the current implementation is not robust

That comment is targeted to #143, which does not pass acceptance. The changes this PR brings compared to v0.9.1 are described in description. Currently there is no other way to measure robustness than acceptance tests and opentmi results to some extent.