search

ARMmbed / mbed-hal-nrf51822-mcu

mbed HAL port for nRF51822
9 stars 12 forks source link

Pin definitions in chip_pins.array not complete #19

Open marcuschangarm opened 8 years ago

marcuschangarm commented 8 years ago

The file should include the P0_0 - P0_30 names as well, since these are chip specific and common to all targets derived from it.

https://github.com/ARMmbed/mbed-hal-nrf51822-mcu/blob/master/mbed-hal/chip_pins.array#L1-L31

rainierwolfcastle commented 8 years ago

ARM Internal Ref: IOTSFW-1157

andresag01 commented 8 years ago

@marcuschangarm: The definitions in chip_pins.array are chip-specific. The definitions for P0_0 -P0_30 were consider target-specific and are all in terms of the definitions found in chip_pins.array. Therefore, these can be found in the actual target.json files for mkit, nrf51dk, etc. Have a look at this one for instance: https://github.com/ARMmbed/target-mkit-gcc/blob/master/target.json.

rgrover commented 8 years ago

@marcuschangarm do you require further work on this?

marcuschangarm commented 8 years ago

That is my point. The names P0_0 - P0_30 are used by Nordic in their chip documentation.

Page 11: https://www.nordicsemi.com/eng/nordic/download_resource/20339/13/5028334

rgrover commented 8 years ago

bump @andresag01

rosterloh commented 8 years ago

Is there a reason why P0_31 is not included in the pin array?

andresag01 commented 8 years ago

@rosterloh: There are multiple types of packages for the nRF51 according to the documentation here. The QF packages do not have pin P0_30 while other packages do have it. Originally these yotta modules were written to be used with mkit and nrf51dk which have a QF package; therefore, pin P0_31 is not defined. However, this is clearly an issue for some targets and we will be addressing it soon.