search

ARMmbed / mbed-hal-st-stm32f4

mbed HAL for ST STM32F4-series microcontrollers
Other
7 stars 21 forks source link

Change macro names to 'MODULES_*' #43

Closed betzw closed 8 years ago

betzw commented 8 years ago

in order to align with 'mbed-drivers' usage of this type of macros.

See also PR https://github.com/ARMmbed/mbed-hal-st-stm32f401re/pull/8

betzw commented 8 years ago

@0xc0170 is there a way to inform Jenkins CI that a certain PR depends on another one in a different repo to get also merged in order to pass the tests?

0xc0170 commented 8 years ago

@0xc0170 is there a way to inform Jenkins CI that a certain PR depends on another one in a different repo to get also merged in order to pass the tests?

No, currently not. For the PR like this, modules_ PR would get merged first, jenkins restarted afterwards for this PR. cc @PrzemekWirkus, the feature might be useful :)

betzw commented 8 years ago

But merging first PR https://github.com/ARMmbed/mbed-hal-st-stm32f401re/pull/8 would lead (temporarily) to a situation in which the actual master branches of the two repos mbed-hal-st-stm32f4 and mbed-hal-st-stm32f401re are not consistent among each other (i.e. do not compile together). Furthermore changing these macro names must be done for all STM32F4xx platforms, so the problem spans even over more than two repos!

0xc0170 commented 8 years ago

@betzw You could make it backward compatible? I haven't checked the current tree dependencies, would it help if here you would do

#ifndef MODULES_SIZE_SPI
#define MODULES_SIZE_SPI MODULE_SIZE_SPI
#endif

Or you can use more narrow dependencies if required.

betzw commented 8 years ago

Good idea! But I think once all F4 platforms have adjusted their macro definitions we should remove the 

#ifndef ... 
#define ... 
#endif

again. What do you think?

0xc0170 commented 8 years ago

// Temporary workaround to pass Jenkins CI

It's not for jenkins but for anyone who uses this module. Yes, seems fine now.

To illustrate what I meant with narrowing down dependencies, might help you in the future. Lets say stm32f4xxx is as target dependency specified ^1.0.5. Once you update that module (for instance to 1.0.6), you can update the module dependency to ^1.0.6 and remove the changes (trick with ifdef above) for this update.

betzw commented 8 years ago

Thanks a lot for the hint on dependencies. I'll give it a try.