search

ARMmbed / mbed-hal-st-stm32f4

mbed HAL for ST STM32F4-series microcontrollers
Other
7 stars 21 forks source link

suppress warnings from 3rd party code #6

Closed autopulated closed 9 years ago

autopulated commented 9 years ago

cr @bremoran @0xc0170

bremoran commented 9 years ago

So long as it builds, I'm happy ;)

0xc0170 commented 9 years ago

I am not much inclined for this, -1

We could easily fix these warnings (not sending a false signal - this is how we fix warnings :facepunch: ). Because these files in this repo are part of the porting process (new files), thus these warnings could be fixed in a timely manner (no waiting for any 3rd party library update).

bogdanm commented 9 years ago

I'm with @0xc0170. It feels like we're cheating instead of dealing with the problem properly.

0xc0170 commented 9 years ago

The implicit warning for pinmap_function just revealed that stmf4 hal invokes pinmap functions which are not in our hal :tired_face:: I'll create an issue for that plus fix the other warnings, new PR incoming.

I'll close this.

autopulated commented 9 years ago

ok :stuck_out_tongue_winking_eye: