search

ARMmbed / mbed-os-example-ble

BLE demos using mbed OS and mbed cli
Apache License 2.0
134 stars 118 forks source link

Add EP_Agora config in Json file #247

Closed deepikabhavnani closed 5 years ago

deepikabhavnani commented 5 years ago

Agora board was added in https://github.com/ARMmbed/mbed-os/pull/10629

PR to be merged after mbed-os.lib is updated to release version 5.13.1 or later

maclobdell commented 5 years ago

Can these configs be handled in targets.json?

deepikabhavnani commented 5 years ago

Can these configs be handled in targets.json?

Yes can be

maclobdell commented 5 years ago

@ARMmbed/team-embeddedplanet Please take a look at these configuration options to enable the BLE stack on Agora. It seems more efficient to add these for your target by default in targets.json. Please evaluate and make a PR if that makes sense to you.

deepikabhavnani commented 5 years ago

@maclobdell - I checked the targets.json, EP_AGORA inherits from MCU_NRF52840 and it has correct configs set already https://github.com/ARMmbed/mbed-os/blob/master/targets/targets.json#L7253 in master branch.

Example instead should be updated to latest release.