search

ARMmbed / mbed-os-example-ble

BLE demos using mbed OS and mbed cli
Apache License 2.0
134 stars 118 forks source link

COMPONENT_BlueNRG_MS creation in mbed-os #284

Closed jeromecoutant closed 4 years ago

jeromecoutant commented 4 years ago

Hi

BlueNRG chip is now a mbed-os BLE component.

PR needed for: https://github.com/ARMmbed/mbed-os/pull/12456

jeromecoutant commented 4 years ago

@LMESTM @0xc0170 @pan-

jeromecoutant commented 4 years ago

@0xc0170 could you start review for this one in order to restart ARMmbed/mbed-os#12456 ? Thx

MarceloSalazar commented 4 years ago

@0xc0170 please review

0xc0170 commented 4 years ago

This needs a rebase, but still @ARMmbed/mbed-os-pan needs to review, will poke the team

jeromecoutant commented 4 years ago

Rebase done

jeromecoutant commented 4 years ago

@LDong-Arm Could you review ? Thx

0xc0170 commented 4 years ago

@LDong-Arm Can this proceed to be integrated?

LDong-Arm commented 4 years ago

@LDong-Arm Can this proceed to be integrated?

@0xc0170 This depends on https://github.com/ARMmbed/mbed-os/pull/12456 being merged first, otherwise the examples here won't compile

jeromecoutant commented 4 years ago

chicken and egg....

0xc0170 commented 4 years ago

@0xc0170 This depends on ARMmbed/mbed-os#12456 being merged first, otherwise the examples here won't compile

Rather break this example for a minute than Mbed OS master (its very sensitive these days to CI failures as there were quite a few). I would suggest to merge this, PR to Mbed OS right away (tested) and retest the example. Including manual example test that all is fine for this example with the PR from Mbed OS.

0xc0170 commented 4 years ago

@ARMmbed/mbed-os-pan Who can approve and merge this one?

MarceloSalazar commented 4 years ago

@ARMmbed/mbed-os-pan can you please review?

pan- commented 4 years ago

@jeromecoutant Could you rebase, I will merge then.

jeromecoutant commented 4 years ago

@jeromecoutant Could you rebase, I will merge then.

Done

0xc0170 commented 4 years ago

@pan- Can we merge this?