search

ARMmbed / mbed-os-example-ble

BLE demos using mbed OS and mbed cli
Apache License 2.0
134 stars 118 forks source link

Update BLE_SM filesystem support specific code #334

Closed AGlass0fMilk closed 3 years ago

AGlass0fMilk commented 3 years ago

Fixes references to fully qualified types in the BLE stack that have since changed namespace. This issue would only occur when the user enabled filesystem support by adding:

"config": {
   "filesystem-support": true
}

To their mbed_app.json

Adds the app.filesystem-support configuration option (previously only mentioned in the example's code) to the mbed_app.json file.

Finally, this also adds an explanation for the topic discussed in #335 and shows how to use the new Gap::EventHandler::onPrivacyEnabled callback introduced in mbed-os-6.4.0

Perhaps this application configuration option can be added to CI builds to catch these simple errors?

Resolves #335

paul-szczepanek-arm commented 3 years ago

Sorry, this indeed looks like it's broken. This has since been fixed on the development branch. On mbed-os examples, development is done on the development branch, master is only updated on release, I'll get back to you when everyone else wakes up on what we can do in this case

paul-szczepanek-arm commented 3 years ago

I am in fact missing the default value in the fixed example, thank you @AGlass0fMilk , could you review the https://github.com/ARMmbed/mbed-os-example-ble/pull/336 ?

AGlass0fMilk commented 3 years ago

Closing this since it is fixed in development branch.

I will make sure to check development next time :smile: