search

ARMmbed / mbed-os-example-ble

BLE demos using mbed OS and mbed cli
Apache License 2.0
134 stars 117 forks source link

BLE_GattServer_AddService: add mbed-trace feature #371

Closed jeromecoutant closed 3 years ago

jeromecoutant commented 3 years ago

Hi

This proposition has no impact by default. But user is now able to easily enable mbed-trace for debugging.

Thx

paul-szczepanek-arm commented 3 years ago

Yes, sorry, I have a PR outstanding that does exactly that: https://github.com/ARMmbed/mbed-os-example-ble/pull/352 I just never got round to rebasing it after we finally merged tracing in mbed-os. Will get this into next sprint this Thursday.

paul-szczepanek-arm commented 3 years ago

I will also improve it by using the ifdefs like you did.

paul-szczepanek-arm commented 3 years ago

the ifdefs are redundant as the header already contains dummies to take care of it when tracing disabled so I left them out. Closing as this PR https://github.com/ARMmbed/mbed-os-example-ble/pull/352 will provide tracing.