search

ARMmbed / mbed-os-example-cellular

This is an example based on mbed-os cellular APIs that demonstrates a TCP or UDP echo transaction with a public echo server.
Apache License 2.0
21 stars 45 forks source link

TCP socket, and status info #45

Closed ghost closed 6 years ago

adbridge commented 6 years ago

@TeemuKultala So if I understand your change correctly it is going to sit there printing : "Connection not ready..." "Connection not ready..." "Connection not ready..."

Every 4 seconds ? I will tag Marcelo to see if he thinks that is a good user experience.

I think he was expecting something more along the lines of : "Establishing connection ..............................." where each dot was added after a certain time. @MarceloSalazar

MarceloSalazar commented 6 years ago

@adbridge is correct, I was thinking on something simple with simple dots.

Edit:

@TeemuKultala just wanted to comment that this is definitely much better to what we had earlier :) IMO the main goal of the task is achieved: provide regular updates the user to the know what's going on. It would be nice to provide updates on what's happening (e.g application trying to connect, not just the latest status). Maybe a simple tweak on your proposal would work: "Connection not yet ready. Attempting to connect". But as I said, this is a minor comment, overall looks really good. Thanks!

MarceloSalazar commented 6 years ago

Thanks everyone!

adbridge commented 6 years ago

@TeemuKultala @hasnainvirk Can we get this merged please ?