search

ARMmbed / mbed-os-example-filesystem

The Mbed OS file system example
https://mbed.com
Apache License 2.0
16 stars 33 forks source link

BUTTON1 not defined for all platforms #76

Closed maclobdell closed 4 years ago

maclobdell commented 5 years ago

This example uses the pin name BUTTON1 in main.cpp. However, there is no standard that ensures that this name will be defined. I recommend changing "BUTTON1" to "MBED_CONF_BUTTON1" or something like that, adding it to the definitions in mbed_app.json file, then allowing target overrides section to define custom definitions for various boards.

ciarmcom commented 5 years ago

Internal Jira reference: https://jira.arm.com/browse/MBOCUSTRIA-255

adbridge commented 4 years ago

Apologies, this was closed in error by the automated bot - re-opening.

MarceloSalazar commented 4 years ago

This is being addressed here: https://github.com/ARMmbed/mbed-os/pull/12838 Specific task on updating the example will come later.