search

ARMmbed / mbed-os-experimental-ble-services

Incubator of Bluetooth services
Apache License 2.0
7 stars 8 forks source link

Directory structure adr #15

Closed paul-szczepanek-arm closed 3 years ago

paul-szczepanek-arm commented 3 years ago

We need to agree on this so we don't clash. Please comment on the proposal.

pan- commented 3 years ago

You forgot to change the include structure in https://github.com/ARMmbed/mbed-os-experimental-ble-services/pull/15/commits/003fe26ca7f7360e78a3ad2d42437d0db718441b

paul-szczepanek-arm commented 3 years ago

Sorry, it's the constant timeouts yesterday (it messes up github desktop).

pan- commented 3 years ago

@AGlass0fMilk Are you happy with the proposed structure ?

paul-szczepanek-arm commented 3 years ago

I thought the idea was that once the service stops being experimental it can be moved to mbed-os. Is that not the case?

pan- commented 3 years ago

I thought the idea was that once the service stops being experimental it can be moved to mbed-os. Is that not the case?

It is all about the level of support and integration. Given the trend I think it would not be moved to Mbed OS.

@AGlass0fMilk It would be great to have reusable utilities/helper classes shared across the services of the repo. I can open an ADR to discuss of the location.

pan- commented 3 years ago

@AGlass0fMilk Are you satisfied with the updates made to the document ? It would be good to reach consensus rapidly so it doesn't block other PRs.