Switch to using TF-M v1.2

[jainvikas8]

This update is related to making CoreIPC.config working with TF-M v1.2.

build_tfm.py:

• Remove MCUboot and mbed-crypto clones
• Change TF-M v1.2 config command
• Log additional info when copying files and folders
• Build all TF-M targets

psa_builder.py

• Cosmetic changes
• Update repo URLs

tfm_ns_import.yaml

• Update paths, files and folder names

Reviwers : @LDong-Arm @evedon @Patater @urutva

[jainvikas8]

Travis should pass after - https://github.com/ARMmbed/mbed-os/pull/14187 is merged

[jainvikas8]

Forced pushed to use ninja.

[LDong-Arm]

Presumably this fixes #12 too.

[jainvikas8]

Forced pushed to use TARGET_TFM_LATEST folder.

[jainvikas8]

@jainvikas8 You need to add ninja-build to the list packages (line 26) in .travis.yml. Hopefully Travis CI will pass then.

Good, at least it tests ninja is not installed.

[jainvikas8]

Forced pushed, to add ninja build

[LDong-Arm]

The copying of crypto_extra.h by tfm_ns_import.yaml overrides https://github.com/ARMmbed/mbed-os/commit/e2e2d0b1f6145c5378c0f64dd5000ea5c2291149. A basic question is, do we need to copy these files every time (since they are already committed to Mbed OS), or is that .yaml mainly to allow testing of any local changes? If we keep the copying, then the solution would be adding the patch to https://github.com/ARMmbed/trusted-firmware-m/tree/mbed-tfm-1.2 too.

[jainvikas8]

The copying of crypto_extra.h by tfm_ns_import.yaml overrides ARMmbed/mbed-os@e2e2d0b. A basic question is, do we need to copy these files every time (since they are already committed to Mbed OS), or is that .yaml mainly to allow testing of any local changes? If we keep the copying, then the solution would be adding the patch to https://github.com/ARMmbed/trusted-firmware-m/tree/mbed-tfm-1.2 too.

I think we need to raise this - https://github.com/ARMmbed/mbed-os/commit/e2e2d0b1f6145c5378c0f64dd5000ea5c2291149 as a patch on https://github.com/ARMmbed/trusted-firmware-m/tree/mbed-tfm-1.2 and also check if we see the same issue on Vanilla TF-M v1.2 with ARM toolchain.

To answer the question, this file doesn't need to be copied every time unless we are upgrading from TF-M v1.2 -> TF-M1.x (for same or new target), because we mostly use the same PSA API version for all the targets.

But this will help when we do continuous integration of Mbed OS + TFM latest

[LDong-Arm]

I think we need to raise this - ARMmbed/mbed-os@e2e2d0b as a patch on https://github.com/ARMmbed/trusted-firmware-m/tree/mbed-tfm-1.2 and also check if we see the same issue on Vanilla TF-M v1.2 with ARM toolchain.

I will raise it. Otherwise we won't be able to compile Mbed applications including the regression and PSA tests.

[jainvikas8]

Forced pushed to fix review comments.

[jainvikas8]

I think we need to raise this - ARMmbed/mbed-os@e2e2d0b as a patch on https://github.com/ARMmbed/trusted-firmware-m/tree/mbed-tfm-1.2 and also check if we see the same issue on Vanilla TF-M v1.2 with ARM toolchain.

I will raise it. Otherwise we won't be able to compile Mbed applications including the regression and PSA tests.

I have checked the Vanilla TF-M build with ARM toolchain, it doesn't seem to have this issue. So this is related to Mbed CLI 1 when using Mbed OS.

[LDong-Arm]

I have checked the Vanilla TF-M build with ARM toolchain, it doesn't seem to have this issue. So this is related to Mbed CLI 1 when using Mbed OS.

It's not related to the toolchain or Mbed CLI, the problem is Mbed TLS compatibility. Vanilla TF-M only compiles a small part of Mbed TLS that it uses, but Mbed OS compiles the whole Mbed TLS because some other components (e.g. network) needs it. One such file is pk.c which requires ARMmbed/mbed-os@e2e2d0b. So we need to fix that.

[LDong-Arm]

https://github.com/ARMmbed/trusted-firmware-m/pull/11 created as a follow-up